bpo-29718: Fixed compile on cygwin.#447
Closed
AraHaan wants to merge 2 commits intopython:masterfrom
AraHaan:cygwin-3.7-patch
Closed
bpo-29718: Fixed compile on cygwin.#447AraHaan wants to merge 2 commits intopython:masterfrom AraHaan:cygwin-3.7-patch
AraHaan wants to merge 2 commits intopython:masterfrom
AraHaan:cygwin-3.7-patch
Conversation
AraHaan
commented
Mar 4, 2017
Modules/timemodule.c
Outdated
| return p->tm_gmtoff; | ||
| #else | ||
| return timegm(p) - t; | ||
| - return timegm(p) - t; |
Contributor
Author
There was a problem hiding this comment.
oops looks like I added an wild -.
vstinner
requested changes
Mar 4, 2017
Member
vstinner
left a comment
There was a problem hiding this comment.
Need more explanation on the reason of the change, let's discuss that on the bug report.
Contributor
Author
|
Now that I think of it I think having TSS instead of TLS on all platforms if possible would be better sollution so that way cygwin would be unofficially supported until we get build bots for cygwin somehow. The trick is figuring out how to make one similar to the windows (MSVC) build bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.7 had an issue just like 3.6 with the TLS entries. As such the only way to compile on Cygwin was to replace TLS with TSS. This also fixes issues that was present in the standard library and setup.py in the repo for cygwin as well. TSS is the thing that actually gets python 3.7 to work on cygwin and in fact the only thing currently so TLS is not really used on it at all after this is merged. This will not affect building on MAC, windows, nor even linux at all it will only affect cygwin.