bpo-31971: Fix IDLE test failure.#4330
Closed
terryjreedy wants to merge 2 commits intopython:masterfrom
Closed
Conversation
On one machine, tk see a mouse cursor hovering over one widget.
Member
Author
|
The two changes are the addition of try: except, so that failure here does not cause a failure elsewhere, and the loosening of the condition for testing the state of |
vstinner
reviewed
Nov 8, 2017
| @@ -844,22 +844,24 @@ def test_set_keys_type(self): | |||
| eq = self.assertEqual | |||
| d = self.page | |||
| del d.set_keys_type | |||
Member
There was a problem hiding this comment.
I suggest to put the del inside the try block as well.
vstinner
reviewed
Nov 8, 2017
| @@ -0,0 +1,3 @@ | |||
| Fix IDLE test failure. | |||
|
|
|||
| On one machine, tk sees a mouse cursor hovering over one widget. | |||
Member
There was a problem hiding this comment.
I'm not sure how this NEWS entry is rendered in HTML. I suggest to put both sentences on the same line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On one machine, tk see a mouse cursor hovering over one widget.
https://bugs.python.org/issue31971