Skip to content

bpo-31781: Prevent crashes when calling methods of an uninitialized zipimport.zipimporter object #3986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brettcannon merged 2 commits into from
Oct 20, 2017
Merged

bpo-31781: Prevent crashes when calling methods of an uninitialized zipimport.zipimporter object #3986

brettcannon merged 2 commits into from
Oct 20, 2017

Conversation

@orenmn
Copy link
Contributor

@orenmn orenmn commented Oct 13, 2017 •
edited by bedevere-bot
Loading

In addition, add a test to test_zipimport to make sure that the crashes are no more.

https://bugs.python.org/issue31781

@orenmn orenmn requested a review from a team October 13, 2017 19:27
brettcannon
brettcannon approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brettcannon brettcannon merged commit db60a5b into python:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@orenmn @brettcannon @the-knights-who-say-ni @bedevere-bot