Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 28, 2022

(cherry picked from commit 0dfabf9)

Co-authored-by: Steve Dower steve.dower@python.org

https://bugs.python.org/issue47138

…other platforms (pythonGH-32161)

(cherry picked from commit 0dfabf9)

Co-authored-by: Steve Dower <steve.dower@python.org>
@miss-islington
Copy link
Contributor Author

@zooba: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor Author

@zooba: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@zooba: Status check is done, and it's a success ✅ .

if errorlevel 1 (
echo Installing sphinx with %PYTHON%
%PYTHON% -m pip install sphinx==2.2.0
%PYTHON% -m pip install -r requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3.7 branch does not have a requirements.txt for the Doc venv.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I should've been checking that as I backported. Looks like it's a different fix for this version (and 3.8)

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@zooba zooba closed this Mar 29, 2022
@miss-islington miss-islington deleted the backport-0dfabf9-3.7 branch March 29, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants