gh-91246: Make zlib required instead of optional.#32043
Closed
gpshead wants to merge 3 commits intopython:mainfrom
Closed
gh-91246: Make zlib required instead of optional.#32043gpshead wants to merge 3 commits intopython:mainfrom
gpshead wants to merge 3 commits intopython:mainfrom
Conversation
This simplifies code by removing a pile of conditionals and alternative logic. Further simplification could be done in `Modules/binascii.c` to simply have binascii.crc32 be a reference to zlib.crc32. Also the conditional logic around zlib inflaceCopy existing and `HAVE_ZLIB_COPY` can likely be removed as that API was added to zlib in 2003. The Windows build already treats zlib as required.
Contributor
|
can you remove |
Member
|
Continued in #130234. |
4 tasks
Member
|
Unfortunately most of this work can only be done when zlib is fully unsupported -- I am happy to come back to it then and finish it off :-) Partial unsupport (Petr's plan): #130297 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies code by removing a pile of conditionals and
alternative logic.
Further simplification could be done in
Modules/binascii.ctosimply have binascii.crc32 be a reference to zlib.crc32.
Also the conditional logic around zlib inflateCopy existing and
HAVE_ZLIB_COPYcan likely be removed as that API was added to zlibin 2003 and Python in 2006 via https://bugs.python.org/issue1503046.
The Windows build already treats zlib as required.
https://bugs.python.org/issue47090