Skip to content

bpo-46848: Move _PyBytes_Find() to internal C API#31642

Merged
vstinner merged 1 commit intopython:mainfrom
vstinner:pycore_bytesobject
Mar 2, 2022
Merged

bpo-46848: Move _PyBytes_Find() to internal C API#31642
vstinner merged 1 commit intopython:mainfrom
vstinner:pycore_bytesobject

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Mar 2, 2022

Move _PyBytes_Find() and _PyBytes_ReverseFind() functions to the
internal C API.

bytesobject.c now includes pycore_bytesobject.h.

https://bugs.python.org/issue46848

Move _PyBytes_Find() and _PyBytes_ReverseFind() functions to the
internal C API.

bytesobject.c now includes pycore_bytesobject.h.
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 2, 2022

cc @sweeneyde

@arhadthedev
Copy link
Copy Markdown
Member

arhadthedev commented Mar 2, 2022

The issue number looks misprinted. bpo-46848 is Use optimized string search function in mmap.find() with no mention of _PyBytes_Find inside.

@sweeneyde
Copy link
Copy Markdown
Member

The issue number looks misprinted. bpo-46848 is Use optimized string search function in mmap.find() with no mention of _PyBytes_Find inside.

GH-31625 introduced it, but it should have gone in the private API.

@vstinner vstinner merged commit b6b711a into python:main Mar 2, 2022
@vstinner vstinner deleted the pycore_bytesobject branch March 2, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants