Skip to content

[3.6] bpo-31160: Backport reap_children() fixes from master to 3.6 #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner wants to merge 2 commits into from
Closed

[3.6] bpo-31160: Backport reap_children() fixes from master to 3.6 #3046

vstinner wants to merge 2 commits into from

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Aug 9, 2017 •
edited by bedevere-bot
Loading

vstinner added 2 commits August 9, 2017 18:01
@vstinner
bpo-31160: Fix test_builtin for zombie process (#3043)
c855914 
PtyTests.run_child() now calls os.waitpid() to read the exit status
of the child process to avoid creating zombie process and leaking
processes in the background.
(cherry picked from commit 4baca1b)
@vstinner
bpo-31160: regrtest now reaps child processes (#3044)
b9617cc 
Add a post_test_cleanup() function which currently only calls
support.reap_children().
(cherry picked from commit e3510d7)
@vstinner
Copy link
Member Author

vstinner commented Aug 9, 2017

The test_builtin change is wrong: http://bugs.python.org/issue31160#msg300024

@vstinner
Copy link
Member Author

vstinner commented Aug 10, 2017

I abandon this PR. I will redo it once I will have merged all reap_children() fixes into master, and that buildbots confirmed that everything is fine. More fixes are required than expected.

@vstinner vstinner closed this Aug 10, 2017
@vstinner vstinner deleted the reap_children36 branch August 10, 2017 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @the-knights-who-say-ni