[3.10] bpo-44649: Fix dataclasses(slots=True) with a field with a default, but init=False (GH-29692)#29704
Merged
miss-islington merged 1 commit intopython:3.10from Nov 22, 2021
Conversation
…ut init=False (pythonGH-29692) Special handling is needed, because for non-slots dataclasses the instance attributes are not set: reading from a field just references the class's attribute of the same name, which contains the default value. But this doesn't work for classes using __slots__: they don't read the class's attribute. So in that case (and that case only), initialize the instance attribute. Handle this for both normal defaults, and for fields using default_factory. (cherry picked from commit d3062f6) Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
ericvsmith
approved these changes
Nov 22, 2021
Contributor
Author
|
Sorry, I can't merge this PR. Reason: |
Contributor
Author
|
@ericvsmith: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Special handling is needed, because for non-slots dataclasses the instance attributes are not set: reading from a field just references the class's attribute of the same name, which contains the default value. But this doesn't work for classes using
__slots__: they don't read the class's attribute. So in that case (and that case only), initialize the instance attribute. Handle this for both normal defaults, and for fields using default_factory.(cherry picked from commit d3062f6)
Co-authored-by: Eric V. Smith ericvsmith@users.noreply.github.com
https://bugs.python.org/issue44649
Automerge-Triggered-By: GH:ericvsmith