Skip to content

bpo-45113: Add PyStructSequence_FromModuleAndDesc() to create a new struct sequence type.#28573

Closed
shihai1991 wants to merge 4 commits intopython:mainfrom
shihai1991:bpo_45113_3
Closed

bpo-45113: Add PyStructSequence_FromModuleAndDesc() to create a new struct sequence type.#28573
shihai1991 wants to merge 4 commits intopython:mainfrom
shihai1991:bpo_45113_3

Conversation

@shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Sep 26, 2021

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@shihai1991 shihai1991 requested a review from encukou October 7, 2021 01:08
@shihai1991
Copy link
Member Author

Hi, Petr. Would you mind to take a look? @encukou
PyType_FromSpecWithBases() allocates tp_members when I call this function. So I think the tp_members of struct sequence can be maintained.

* main: (263 commits)
  bpo-45521: Fix a bug in the obmalloc radix tree code. (pythonGH-29051)
  bpo-45522: Allow to disable freelists on build time (pythonGH-29056)
  bpo-34451: Document prompt and output toggle feature in html tutorial (pythonGH-27105)
  bpo-44019: Add operator.call() to __all__ for the operator module (pythonGH-29110)
  bpo-45315: PyType_FromSpec: Copy spec->name and have the type own the memory for its name (pythonGH-29103)
  bpo-44220: Export PyStructSequence_UnnamedField in the limited API (pythonGH-26331)
  bpo-44174: [Enum] add reference to name mangling (pythonGH-29116)
  bpo-45548: add some missing entries to `Modules/Setup` (pythonGH-29115)
  bpo-35673: Add a public alias for namespace package __loader__ attribute (python#29049)
  bpo-45192: Fix a bug that infers the type of an os.PathLike[bytes] object as str (pythonGH-28323)
  bpo-45527: Don't count cache hits, just misses. (pythonGH-29092)
  bpo-45320: Remove long-deprecated inspect methods (pythonGH-28618)
  bpo-41374: Remove obsolete exclusion of netinet/tcp.h on Cygwin (pythonGH-21649)
  bpo-45532: Replace 'default' with 'main' as default in sys.version (pythonGH-29100)
  bpo-45464: [doc] Explain that subclassing multiple exceptions is fragile (pythonGH-29094)
  Cleanup a couple of comments left on PR 28775 post-merge. (pythonGH-29079)
  bpo-45536: Check OpenSSL APIs in configure (pythonGH-29088)
  Add PEPs 593 & 647 to list of PEPs at top of typing docs (pythonGH-29097)
  Add a comment about how to fix bogus test_host_resolution_bad_address failures (python#29085)
  bpo-44525: Specialize simple Python calls. (pythonGH-29033)
  ...
@shihai1991 shihai1991 requested review from encukou and tiran October 23, 2021 06:21
@shihai1991
Copy link
Member Author

Thanks for review this PR. I close this PR as Petr said in https://bugs.python.org/issue45113#msg406408.

@shihai1991 shihai1991 closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants