Skip to content

bpo-45061: Revert unicode_is_singleton() change#28516

Merged
vstinner merged 1 commit intopython:mainfrom
vstinner:unicode_is_singleton
Sep 22, 2021
Merged

bpo-45061: Revert unicode_is_singleton() change#28516
vstinner merged 1 commit intopython:mainfrom
vstinner:unicode_is_singleton

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Sep 22, 2021 •
edited by bedevere-bot
Loading

Don't use a loop over 256 items, only checks for a single singleton.

https://bugs.python.org/issue45061

@vstinner
bpo-45061: Revert unicode_is_singleton() change
55ec4ec 
Don't use a loop over 256 items, only checks for a single singleton.
@vstinner vstinner merged commit 8620be9 into python:main Sep 22, 2021
@vstinner vstinner deleted the unicode_is_singleton branch September 22, 2021 10:16
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 22, 2021 •
edited
Loading

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux Asan Debug 3.x has failed when building commit 8620be9.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/585/builds/570) and take a look at the build logs.
  4. Check if the failure is related to this commit (8620be9) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/585/builds/570

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 4, done.        
remote: Counting objects:  33% (1/3)        
remote: Counting objects:  66% (2/3)        
remote: Counting objects: 100% (3/3)        
remote: Counting objects: 100% (3/3), done.        
remote: Total 4 (delta 3), reused 3 (delta 3), pack-reused 1        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '8620be99da930230b18ec05f4d7446ee403531af'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 8620be99da [bpo-45061](https://bugs.python.org/issue45061): Revert unicode_is_singleton() change (GH-28516)
Switched to and reset branch 'main'

./configure: line 10581: PKG_PROG_PKG_CONFIG: command not found

In file included from /buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan_debug/build/Modules/expat/expat_config.h:8,
                 from /buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan_debug/build/Modules/expat/xmltok.c:53:
./pyconfig.h:1634: warning: "_POSIX_C_SOURCE" redefined
 1634 | #define _POSIX_C_SOURCE 200809L
      | 
In file included from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/string.h:26,
                 from /buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan_debug/build/Modules/expat/xmltok.c:46:
/usr/include/features.h:310: note: this is the location of the previous definition
  310 | # define _POSIX_C_SOURCE 199506L
      | 
renaming build/scripts-3.11/pydoc3 to build/scripts-3.11/pydoc3.11
renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11
renaming build/scripts-3.11/2to3 to build/scripts-3.11/2to3-3.11

renaming build/scripts-3.11/pydoc3 to build/scripts-3.11/pydoc3.11
renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11
renaming build/scripts-3.11/2to3 to build/scripts-3.11/2to3-3.11

renaming build/scripts-3.11/pydoc3 to build/scripts-3.11/pydoc3.11
renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11
renaming build/scripts-3.11/2to3 to build/scripts-3.11/2to3-3.11
test_devpoll skipped -- test works only on Solaris OS family
test_ioctl skipped -- Unable to open /dev/tty
test_startfile skipped -- object <module 'os' from '/buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan_debug/build/Lib/os.py'> has no attribute 'startfile'
<string>:2: DeprecationWarning: lib2to3 package is deprecated and may not be able to parse Python 3.10+
test_kqueue skipped -- test works only on BSD
test_badargs (__main__.GeneralTest) ... ok
test_bound_methods (__main__.GeneralTest) ... ok
test_clear (__main__.GeneralTest) ... ok
test_exit (__main__.GeneralTest) ... ok
test_order (__main__.GeneralTest) ... ok
test_raise (__main__.GeneralTest) ... ok
test_raise_unnormalized (__main__.GeneralTest) ... ok
test_stress (__main__.GeneralTest) ... ok
test_unregister (__main__.GeneralTest) ... ok

----------------------------------------------------------------------
Ran 9 tests in 0.003s

OK
test_winreg skipped -- No module named 'winreg'
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_tk skipped -- Tk unavailable due to TclError: couldn't connect to display ":99"
test_tix skipped -- Tk unavailable due to TclError: couldn't connect to display ":99"
test_winconsoleio skipped -- test only relevant on win32
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 7.443s

OK (skipped=2)
test_winsound skipped -- No module named 'winsound'
test_ttk_guionly skipped -- Tk unavailable due to TclError: couldn't connect to display ":99"
test_msilib skipped -- No module named '_msi'
make: *** [Makefile:1307: buildbottest] Terminated

Cannot open file '/buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan_debug/build/test-results.xml' for upload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @bedevere-bot @the-knights-who-say-ni