Skip to content

bpo-24234: fix bytes.__bytes__ to not truncate at a zero byte#27902

Merged
mdickinson merged 1 commit into
python:mainfrom
mdickinson:bpo-24234-fix-bytes-bytes
Aug 23, 2021
Merged

bpo-24234: fix bytes.__bytes__ to not truncate at a zero byte#27902
mdickinson merged 1 commit into
python:mainfrom
mdickinson:bpo-24234-fix-bytes-bytes

Conversation

@mdickinson

@mdickinson mdickinson commented Aug 23, 2021

Copy link
Copy Markdown
Member

Fixes buildbot failures introduced in GH-27901.

https://bugs.python.org/issue24234

@mdickinson mdickinson added skip news type-bug An unexpected behavior, bug, or error labels Aug 23, 2021
@mdickinson mdickinson requested a review from corona10 August 23, 2021 10:35
@mdickinson mdickinson added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 23, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 72ea593 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 23, 2021

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdickinson Thank you for quick fix 👍
LGTM

@mdickinson

Copy link
Copy Markdown
Member Author

The s390x buildbot is reporting:

test_typing leaked [1, 1, 1] memory blocks, sum=3

@corona10

Copy link
Copy Markdown
Member

@mdickinson Other Refleak tests doesn't report the issue :(

@mdickinson

Copy link
Copy Markdown
Member Author

I'll merge anyway - this change is obviously needed. The Arch Linux buildbot failure looks unrelated, and has been happening for a while. We can keep an eye on the s390x buildbot for a while to see if the test_typing refleak is persistent.

@mdickinson mdickinson merged commit ae52591 into python:main Aug 23, 2021
@mdickinson mdickinson deleted the bpo-24234-fix-bytes-bytes branch August 23, 2021 14:24
@mdickinson

Copy link
Copy Markdown
Member Author

The s390x buildbot is reporting [...]

There have been 9 runs of that buildbot since; none of them have reproduced that same test_typing leak, so I think we can be reasonably confident that it wasn't caused by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants