Skip to content

bpo-44978: allow Argument Clinic to handle __complex__ special methods#27886

Merged
mdickinson merged 2 commits into
python:mainfrom
mdickinson:fix/clinic-complex-is-not-special
Aug 22, 2021
Merged

bpo-44978: allow Argument Clinic to handle __complex__ special methods#27886
mdickinson merged 2 commits into
python:mainfrom
mdickinson:fix/clinic-complex-is-not-special

Conversation

@mdickinson

@mdickinson mdickinson commented Aug 22, 2021

Copy link
Copy Markdown
Member

As far as I can tell, __complex__ should need no special handling by Argument Clinic, so it should be safe to remove it from the set of unsupported methods. (__int__ and __float__ are there because they make use of a special slot, but __complex__ has no slot.)

https://bugs.python.org/issue44978

@mdickinson

Copy link
Copy Markdown
Member Author

For the record, I successfully implemented complex.__complex__ using Argument Clinic with this change in place. I'll make a separate PR for that.

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@mdickinson mdickinson merged commit c5c3fbe into python:main Aug 22, 2021
@mdickinson mdickinson deleted the fix/clinic-complex-is-not-special branch August 22, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants