bpo-25251:Adding vcruntime140 support to cygwin#26780
Conversation
Fixing the fact that MinGW compilation cygwin will identify it and python as vcruntime140 but there is not a definition for it. Fix taken from: https://www.programmersought.com/article/95064175115/ Noticed it never seems to have been submitted as a pull request to actually apply the fix so submitting my own.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Sorry, this issue has been closed, and distutils is deprecated. I suggest going to https://github.com/pypa/setuptools and making the change there, and then using setuptools to build rather than distutils. |
|
Looks like the code still exists in setuptools. Opened pypa/setuptools#2704 |
Fixing the fact that MinGW compilation cygwin will identify it and python as vcruntime140 but there is not a definition for it. Fix taken from: https://www.programmersought.com/article/95064175115/
Noticed it never seems to have been submitted as a pull request to actually apply the fix so submitting my own.
https://bugs.python.org/issue25251