Skip to content

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 27, 2021

@pablogsal
Copy link
Member Author

❯ ./python -m test test_descr -m test_slots -R :
0:00:00 load avg: 0.36 Run tests sequentially
0:00:00 load avg: 0.36 [1/1] test_descr
beginning 9 repetitions
123456789
.........

== Tests result: SUCCESS ==

1 test OK.

Total duration: 477 ms
Tests result: SUCCESS

@DinoV
Copy link
Contributor

DinoV commented Mar 27, 2021

If you want to add some asserts at the same time, it'd be good to assert assert(_PyType_HasFeature(type, Py_TPFLAGS_VALID_VERSION_TAG)); on a cache hit, and assert(type->tp_version_tag != 0); when we're about to store the cache.

@pablogsal
Copy link
Member Author

If you want to add some asserts at the same time, it'd be good to assert assert(_PyType_HasFeature(type, Py_TPFLAGS_VALID_VERSION_TAG)); on a cache hit, and assert(type->tp_version_tag != 0); when we're about to store the cache.

Done in 589c3da

@pablogsal pablogsal merged commit 11b85ab into python:master Mar 27, 2021
@pablogsal pablogsal deleted the fix_desc branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants