Skip to content

bpo-42129: Add support for resources in namespaces#24670

Merged
jaraco merged 7 commits into
masterfrom
feature/42129-resources-namespace-packages
Mar 4, 2021
Merged

bpo-42129: Add support for resources in namespaces#24670
jaraco merged 7 commits into
masterfrom
feature/42129-resources-namespace-packages

Conversation

@jaraco

@jaraco jaraco commented Feb 28, 2021

Copy link
Copy Markdown
Member

@jaraco

jaraco commented Feb 28, 2021

Copy link
Copy Markdown
Member Author

Annoyingly, this change includes adoption of black in the backport, so includes all of the flux and losses in readability that brings.

@jaraco

jaraco commented Mar 4, 2021

Copy link
Copy Markdown
Member Author

According to the test failures, something is modifying sys.path.

Comment thread Lib/test/test_importlib/test_reader.py Outdated
@jaraco jaraco force-pushed the feature/42129-resources-namespace-packages branch from 84008ab to a7555f6 Compare March 4, 2021 17:59
@jaraco jaraco merged commit 6714825 into master Mar 4, 2021
@jaraco jaraco deleted the feature/42129-resources-namespace-packages branch March 4, 2021 18:43
@kousu

kousu commented Apr 7, 2021

Copy link
Copy Markdown

Thank you so much for this!

I spent a long time this weekend trying to work around this for https://github.com/sct-data/spinalcordtoobox-data-template until I eventually just gave up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants