Skip to content

bpo-42269: Add slots parameter to dataclass decorator#24171

Merged
ericvsmith merged 8 commits intopython:masterfrom
uriyyo:fix-issue-42269
May 1, 2021
Merged

bpo-42269: Add slots parameter to dataclass decorator#24171
ericvsmith merged 8 commits intopython:masterfrom
uriyyo:fix-issue-42269

Conversation

@uriyyo
Copy link
Copy Markdown
Member

@uriyyo uriyyo commented Jan 8, 2021 •
edited by bedevere-bot
Loading

@uriyyo uriyyo requested a review from ericvsmith as a code owner January 8, 2021 20:40
@uriyyo uriyyo changed the title bpo-42269: Add slots parameter to dataclass decorator bpo-42269: Add slots parameter to dataclass decorator Jan 22, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 22, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 22, 2021
@uriyyo
Copy link
Copy Markdown
Member Author

uriyyo commented Feb 25, 2021

Hi @ericvsmith, could you please review this PR?)

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Feb 26, 2021
ericvsmith
ericvsmith requested changes Apr 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the conflicts, @uriyyo!

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 28, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@uriyyo
Copy link
Copy Markdown
Member Author

uriyyo commented Apr 28, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 28, 2021

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ericvsmith April 28, 2021 09:27
@uriyyo
Copy link
Copy Markdown
Member Author

uriyyo commented Apr 28, 2021

@ericvsmith Could you please verify updated docs?

Should we mention this changes at python 3.10 whats new section?

ericvsmith
ericvsmith requested changes Apr 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor grammar nits, otherwise this looks good.

A whats new section for dataclasses is probably a good idea. I also need to add kw_only and match_args, too. I'll add kw_only and match_args after this PR lands.

I hope to get this all committed this weekend so it makes beta1.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 28, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@uriyyo
Copy link
Copy Markdown
Member Author

uriyyo commented Apr 28, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 28, 2021

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ericvsmith April 28, 2021 09:49
@uriyyo
Copy link
Copy Markdown
Member Author

uriyyo commented Apr 28, 2021

Regarding the Whats new. Will you mention the slots feature or should I do it?

@ericvsmith
Copy link
Copy Markdown
Member

ericvsmith commented Apr 28, 2021

You should add slots, I’ll add the others in a different PR.

@uriyyo
Copy link
Copy Markdown
Member Author

uriyyo commented Apr 28, 2021

@ericvsmith Could you please review whats new?

@ericvsmith
Copy link
Copy Markdown
Member

ericvsmith commented Apr 28, 2021

Thanks, @uriyyo. This all looks good. I'll take one last pass at reviewing it this weekend and commit it.

@ericvsmith ericvsmith merged commit c241991 into python:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@uriyyo @bedevere-bot @ericvsmith @the-knights-who-say-ni