Skip to content

[3.8] bpo-42574: Use format() instead of f-string in Tools/clinic/clinic.py to allow using older Python versions#23685

Merged
pablogsal merged 1 commit intopython:3.8from
pablogsal:fix
Dec 7, 2020
Merged

[3.8] bpo-42574: Use format() instead of f-string in Tools/clinic/clinic.py to allow using older Python versions#23685
pablogsal merged 1 commit intopython:3.8from
pablogsal:fix

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented Dec 7, 2020

Copy link
Copy Markdown
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Should this be fixed on 3.7 and 3.6, too? I think CI/tooling fixes are probably fine for security branches, but not sure. Maybe we could just set PYTHON_FOR_REGEN in .travis.yml for those.

@brandtbucher brandtbucher changed the title bpo-42574: Use format() instead of f-string in Tools/clinic/clinic.py to allow using older Python versions [3.8] bpo-42574: Use format() instead of f-string in Tools/clinic/clinic.py to allow using older Python versions Dec 7, 2020
@pablogsal
Copy link
Copy Markdown
Member Author

Should this be fixed on 3.7 and 3.6, too?

#23362 was only bacported to 3.8 no? I may be missing here something, but in any case I would be ok with backporting to 3.7 and 3.6 if applies.

@brandtbucher
Copy link
Copy Markdown
Member

Ah, you're right. I thought it was for some reason.

@pablogsal pablogsal merged commit b6d6f53 into python:3.8 Dec 7, 2020
@pablogsal pablogsal deleted the fix branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants