Skip to content

bpo-42333: Port _ssl extension to multiphase initialization (PEP 489) (GH-23253) #23253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiran merged 1 commit into from
Apr 17, 2021
Merged

bpo-42333: Port _ssl extension to multiphase initialization (PEP 489) (GH-23253) #23253

tiran merged 1 commit into from
Apr 17, 2021

Conversation

@tiran
Copy link
Member

@tiran tiran commented Nov 12, 2020 •
edited by bedevere-bot
Loading

@tiran tiran changed the title bpo-42333: Port ssl module to use heap types and module state bpo-42333: Port _ssl extension to multiphase initialization (PEP 489) Nov 12, 2020
@tiran tiran marked this pull request as ready for review November 12, 2020 22:45
@tiran tiran force-pushed the ssl_modulestate branch 2 times, most recently from 1e5efb9 to 19a9492 Compare November 17, 2020 13:16
@tiran tiran requested review from corona10 and vstinner November 19, 2020 07:17
@github-actions
Copy link

github-actions bot commented Dec 21, 2020

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 21, 2020
@tiran tiran force-pushed the ssl_modulestate branch from 082c80f to e600658 Compare March 27, 2021 14:16
@tiran tiran force-pushed the ssl_modulestate branch 2 times, most recently from a51e0ef to 3c63196 Compare April 17, 2021 17:35
@tiran tiran removed the stale Stale PR or inactive for long period of time. label Apr 17, 2021
@tiran
bpo-42333: Port _ssl extension to multiphase initialization
dfc1ec8 
- Introduce sslmodule_slots
- Introduce sslmodulestate
- Use sslmodulestate
- Get rid of PyState_FindModule
- Move new structs and helpers to header file
- Use macros to access state
- Keep a strong ref to socket type
@tiran tiran force-pushed the ssl_modulestate branch from 3c63196 to dfc1ec8 Compare April 17, 2021 17:38
@tiran tiran changed the title bpo-42333: Port _ssl extension to multiphase initialization (PEP 489) bpo-42333: Port _ssl extension to multiphase initialization (PEP 489) (GH-23253) Apr 17, 2021
@tiran tiran merged commit 7f1305e into python:master Apr 17, 2021
@tiran tiran deleted the ssl_modulestate branch April 17, 2021 18:06
@sthagen sthagen mentioned this pull request Apr 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

@corona10 corona10 Awaiting requested review from corona10

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiran @the-knights-who-say-ni @bedevere-bot