[WIP/RFC] pathlib: revisit error handling#23025
Closed
blueyed wants to merge 2 commits intopython:mainfrom
Closed
Conversation
Refs: - bpo-24120 (python@6c2d33a258bb) uses to broad try/catch for PermissionError, which led to bpo-38894 in the first place - bpo-38894 (python#18815) fixed handling only for `_WildcardSelector` TODO: tests for others?
Member
|
Can you explain in more words what you are proposing here? Maybe even discuss it in the issue (even if closed) first? |
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Contributor
Author
|
This refactors/cleans up the error handling, which is (inconsistently) used in several places (IIRC). |
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
Contributor
|
Closing per my previous comment. Thanks all the same! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
uses to broad try/catch for PermissionError, which led to bpo-38894 in
the first place
fixed handling only for
_WildcardSelectorTODO: tests for others?