bpo-42115: Refactor the opcode cache into its own file #22907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Oct 23, 2020
1st1
reviewed
Oct 23, 2020
1st1
reviewed
Oct 23, 2020
1st1
reviewed
Oct 23, 2020
Member
|
Overall +1. @pablogsal please copy me in opcode cache PRs ;) |
951a785 to
c38a89c
Compare
Apply suggestions from code review Co-authored-by: Yury Selivanov <yury@edgedb.com>
Member
Author
|
I checked and we lose quite a bit of performance (3-4%) due to the extra function calls. I think I am going to close this for now until I devise some better mechanism (maybe the code object mutation is the only way to keep the inlining but separate the different code) :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue42115
The advantage of doing this is that the code in
ceval.cis much easier to manage now.