Skip to content

[3.6] bpo-29887: test_normalization handles PermissionError (#1196)#2275

Merged
vstinner merged 1 commit intopython:3.6from
vstinner:test_normalization36
Jun 19, 2017
Merged

[3.6] bpo-29887: test_normalization handles PermissionError (#1196)#2275
vstinner merged 1 commit intopython:3.6from
vstinner:test_normalization36

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 19, 2017

Skip test_normalization.test_main() if download raises a permission
error.
(cherry picked from commit d13d547)

@vstinner
bpo-29887: test_normalization handles PermissionError (#1196)
d1bd20b 
Skip test_normalization.test_main() if download raises a permission
error.
(cherry picked from commit d13d547)
@vstinner
Copy link
Member Author

vstinner commented Jun 19, 2017

@Mariatta: Oh, your backport broke "x86 Gentoo Installed with X 3.6" buildbot, you forgot to backport my following fix. Usually, I prefer to only modify the master branch to not break too many buildbots, and it's not uncommon that I need a second change to fix all issues ;-)

So here is my backport of the second fix. You need to include this commit in your 3.5 backport as well: PR #2272.

@vstinner
Copy link
Member Author

vstinner commented Jun 19, 2017

The buildbot failure:

======================================================================
FAIL: test_main (test.test_normalization.NormalizationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/buildbot/buildarea/3.6.ware-gentoo-x86.installed/build/target/lib/python3.6/test/test_normalization.py", line 42, in test_main
    check=check_version)
PermissionError: [Errno 13] Permission denied: '/buildbot/buildarea/3.6.ware-gentoo-x86.installed/build/target/lib/python3.6/test/data/NormalizationTest.txt'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/buildbot/buildarea/3.6.ware-gentoo-x86.installed/build/target/lib/python3.6/test/test_normalization.py", line 44, in test_main
    self.fail(f"Could not retrieve {TESTDATAURL}")
AssertionError: Could not retrieve http://www.pythontest.net/unicode/9.0.0/NormalizationTest.txt

http://buildbot.python.org/all/builders/x86%20Gentoo%20Installed%20with%20X%203.6/builds/420/steps/test/logs/stdio

Don't worry about the bug. I reviewed your PR and forgot that I made a second change, it's my fault.

@vstinner vstinner changed the title bpo-29887: test_normalization handles PermissionError (#1196) [3.6] bpo-29887: test_normalization handles PermissionError (#1196) Jun 19, 2017
@vstinner vstinner merged commit acdf159 into python:3.6 Jun 19, 2017
@vstinner vstinner deleted the test_normalization36 branch June 19, 2017 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @the-knights-who-say-ni