bpo-41643: always support pathlib in shutil.make_archive#21962
Closed
graingert wants to merge 3 commits into
Closed
bpo-41643: always support pathlib in shutil.make_archive#21962graingert wants to merge 3 commits into
graingert wants to merge 3 commits into
Conversation
graingert
commented
Aug 26, 2020
graingert
commented
Aug 26, 2020
| @@ -1030,8 +1030,10 @@ def make_archive(base_name, format, root_dir=None, base_dir=None, verbose=0, | |||
| uses the current owner and group. | |||
| """ | |||
Contributor
Author
There was a problem hiding this comment.
not sure what the rules are re-auditing, would it be better to do:
base_name = base_name ?? os.fsdecode(base_name)
root_dir = root_dir ?? os.fsdecode(root_dir)
base_dir = base_dir ?? os.fsdecode(base_dir)
before the audit call or after?
Contributor
Author
There was a problem hiding this comment.
https://peps.python.org/pep-0505/ syntax, but it's not used should be something like
base_name = base_name if base_name is None else os.fsdecode(base_name)
root_dir = root_dir if root_dir is None else os.fsdecode(root_dir)
base_dir = base_dir if base_dir is None else os.fsdecode(base_dir)
Contributor
Author
merwok
reviewed
Jan 5, 2022
| uses the current owner and group. | ||
| """ | ||
| sys.audit("shutil.make_archive", base_name, format, root_dir, base_dir) | ||
| base_name = os.fsdecode(base_name) |
Member
There was a problem hiding this comment.
Isn’t fsdecode about bytes-str decoding, and fspath for pathlike-to-OS-native conversion?
Contributor
|
Hi @graingert. The Would you be okay for this PR to be closed so that I can take this over (I have a complete fix+tests+docs ready) or are you still working on this? |
Contributor
Author
|
Please go ahead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41643