[3.9] bpo-40696: Fix a hang that can arise after gen.throw() (GH-20287)#20322
Merged
cjerdonek merged 1 commit intopython:3.9from May 22, 2020
Merged
[3.9] bpo-40696: Fix a hang that can arise after gen.throw() (GH-20287)#20322cjerdonek merged 1 commit intopython:3.9from
cjerdonek merged 1 commit intopython:3.9from
Conversation
This updates _PyErr_ChainStackItem() to use _PyErr_SetObject() instead of _PyErr_ChainExceptions(). This prevents a hang in certain circumstances because _PyErr_SetObject() performs checks to prevent cycles in the exception context chain while _PyErr_ChainExceptions() doesn't. (cherry picked from commit 7c30d12) Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>
Contributor
Author
|
@cjerdonek: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@cjerdonek: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@cjerdonek: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates _PyErr_ChainStackItem() to use _PyErr_SetObject()
instead of _PyErr_ChainExceptions(). This prevents a hang in
certain circumstances because _PyErr_SetObject() performs checks
to prevent cycles in the exception context chain while
_PyErr_ChainExceptions() doesn't.
(cherry picked from commit 7c30d12)
Co-authored-by: Chris Jerdonek chris.jerdonek@gmail.com
https://bugs.python.org/issue40696