bpo-40155: Stop test_builtin from hanging on AIX, Solaris and maybe others.
#19308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to workaround a side-effect introduced by 16d7567 bpo-31160: Fix race condition in test_os.PtyTests (pythonGH-19263) Patch by M. Felt
test_builtin from hanging on AIX, Solaris and maybe others.test_builtin from hanging on AIX, Solaris and maybe others.
Member
|
I wrote PR #19312 which closes the fd before the wait on all platforms. I just adapted the code to expect the child process to be terminated by SIGHUP. |
Member
|
Thanks. I merged PR #19314 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to workaround a side-effect introduced by
16d7567 bpo-31160: Fix race
condition in test_os.PtyTests (GH-19263)
Patch by M. Felt
I hope this can be merged quickly so the bots can finish normally again.
I did not provide a NEWS blurb. Can be added if desired.
https://bugs.python.org/issue40155