[WIP] bpo-40068: test_reinit_tls_after_fork() detects crashes #19200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@pablogsal: We talked about such idea ;-) |
pablogsal
approved these changes
Mar 27, 2020
Member
pablogsal
left a comment
There was a problem hiding this comment.
Nice! Thanks for working on this :)
Member
Author
|
Hum, I found more code than what I expected which convert a waitpid status to a returncode, so I proposed to even add the helper function directly to the os module: https://bugs.python.org/issue40094 |
test_reinit_tls_after_fork() of test_threading now checks if a child process crashed in os.fork().
Member
Author
|
I rebased my PR on master and reverted changes in _bootsubproces and test.support: I rewrote these changes as a new public function in PR #19201. |
Member
Author
|
I'm working on a different approach: PR #19254. |
Member
Author
|
I merged PR #19260 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_reinit_tls_after_fork() of test_threading now checks if a child
process crashed in os.fork().
https://bugs.python.org/issue40068