Skip to content

bpo-36051: Fix compiler warning.#18325

Merged
methane merged 1 commit into
python:masterfrom
methane:join-warning
Feb 3, 2020
Merged

bpo-36051: Fix compiler warning.#18325
methane merged 1 commit into
python:masterfrom
methane:join-warning

Conversation

@methane

@methane methane commented Feb 3, 2020

Copy link
Copy Markdown
Member

@bmerry bmerry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a core dev, but as the person who accidentally introduced the compiler warning this looks good to me. I wish compilers were a bit smarter about this sort of thing.

@methane methane merged commit 869c0c9 into python:master Feb 3, 2020
@methane methane deleted the join-warning branch February 3, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants