gh-72353: WindowsConsoleIO misbehavior when Ctrl+C is ignored#17976
Open
ZackerySpytz wants to merge 2 commits into
Open
gh-72353: WindowsConsoleIO misbehavior when Ctrl+C is ignored#17976ZackerySpytz wants to merge 2 commits into
ZackerySpytz wants to merge 2 commits into
Conversation
Continue to read if SIGINT is ignored or the handler doesn't raise an exception. Co-Authored-By: Valeriya Sinevich <valeriya.sinevich@phystech.edu>
zooba
reviewed
Feb 29, 2024
| if (WaitForSingleObjectEx(hInterruptEvent, 100, FALSE) | ||
| == WAIT_OBJECT_0) { | ||
| DWORD state = WaitForSingleObjectEx(hInterruptEvent, 100, FALSE); | ||
| if (state == WAIT_OBJECT_0 || state == WAIT_TIMEOUT) { |
Member
There was a problem hiding this comment.
Considering every other possible result is a hard error (which we're currently ignoring... whoops), I don't think this is the right condition.
Probably in the WAIT_TIMEOUT case we want to just continue and not call PyErr_CheckSignals? We certainly shouldn't reset the event, because we haven't been given it
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue to read if SIGINT is ignored or the handler doesn't raise
an exception.
Co-Authored-By: Valeriya Sinevich valeriya.sinevich@phystech.edu
https://bugs.python.org/issue28166