Skip to content

bpo-25430: improve performance of IPNetwork.__contains__#1785

Merged
methane merged 2 commits intopython:masterfrom
gescheit:fix-issue-25430
Apr 30, 2019
Merged

bpo-25430: improve performance of IPNetwork.__contains__#1785
methane merged 2 commits intopython:masterfrom
gescheit:fix-issue-25430

Conversation

@gescheit
Copy link
Copy Markdown
Contributor

@gescheit gescheit commented May 24, 2017

make a compare in bit-operation manner
see http://bugs.python.org/issue25430 for detail

https://bugs.python.org/issue25430

make a compare in bit-operation manner
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@mention-bot
Copy link
Copy Markdown

@gescheit, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @serhiy-storchaka and @hynek to be potential reviewers.

@pitrou
Copy link
Copy Markdown
Member

pitrou commented May 24, 2017

Changed the CLA label as @gescheit is recorded as having signed it in Roundup: https://bugs.python.org/user15300

@pitrou pitrou requested a review from serhiy-storchaka May 24, 2017 11:33
@pitrou pitrou changed the title bpo-25430: performance improvements bpo-25430: improve performance of IPNetwork.__contains__ May 25, 2017
@serhiy-storchaka serhiy-storchaka added the performance Performance or resource usage label Dec 8, 2018
@BoboTiG
Copy link
Copy Markdown
Contributor

BoboTiG commented Dec 11, 2018

Thanks @gescheit, changes looks good to me!
I think adding a NEWs entry would be good too, don't you?

@asvetlov
Copy link
Copy Markdown
Contributor

What is performance boost?

@BoboTiG
Copy link
Copy Markdown
Contributor

BoboTiG commented Dec 12, 2018

@asvetlov you can find numbers in the description of the BPO.

@asvetlov
Copy link
Copy Markdown
Contributor

Got you. Thanks.
Could you please add a NEWS entry?
https://devguide.python.org/committing/?highlight=blurb#what-s-new-and-news-entries

Copy link
Copy Markdown
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS entry is requered

@bedevere-bot
Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tirkarthi
Copy link
Copy Markdown
Member

Ping @gescheit . This seems to be blocking only on NEWS entry. Can you please add one? It would be nice to see this as part of next release. You can add it from the web interface using https://blurb-it.herokuapp.com/ or using the blurb tool at https://pypi.org/project/blurb/

Thanks

@methane methane merged commit 3bbcc92 into python:master Apr 30, 2019
Copy link
Copy Markdown

@Cant2 Cant2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review performance Performance or resource usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.