bpo-38382: Fix premature return on ZeroDivisionError in statistics.harmonic_mean #16601
Conversation
…rmonic_mean * Check for any negative values before attempting to compute the harmonic mean. * The private function _fail_neg is no longer used, so remove it.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
I signed the CLA after submitting this PR. |
|
@WarrenWeckesser Thanks for the contribution. Please add news through blurb |
stevendaprano
left a comment
There was a problem hiding this comment.
I don't think this should be merged until the discussion on b.p.o. comes to a definite conclusion about the action to take.
|
@stevendaprano I agree! |
|
Closing for now. The required action (if any) is under discussion. If there is a change, it almost certainly won't be the change in this PR in its current form. |
https://bugs.python.org/issue38382