Skip to content

bpo-38063: test_socket uses unittest.main() #15751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner wants to merge 1 commit into from
Closed

bpo-38063: test_socket uses unittest.main() #15751

vstinner wants to merge 1 commit into from

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Sep 9, 2019 •
edited by bedevere-bot
Loading

Remove test_main() from test_socket: use setUpModule() with
tearDownModule() and unittest.main() to discover automatically test
cases.

Reorder also imports.

https://bugs.python.org/issue38063

@vstinner
bpo-38063: test_socket uses unittest.main()
a66bd5f 
Remove test_main() from test_socket: use setUpModule() with
tearDownModule() and unittest.main() to discover automatically test
cases.

Reorder also imports.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Sep 9, 2019
@vstinner
Copy link
Member Author

vstinner commented Sep 9, 2019

I tested manually that I get the same number of test methods with and without this change:

# this PR
vstinner@apu$ ./python -m test test_socket --list-cases|wc -l
819

# without this change (reference)
vstinner@apu$ git checkout master
vstinner@apu$ ./python -m test test_socket --list-cases|wc -l
819

zware
zware approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vstinner
Copy link
Member Author

vstinner commented Sep 9, 2019

Oh. "./python -m test test_socket --list-cases" doesn't work as expected. On the master branch, it lists a lot of tests which are not run...

Many tests of test_socket fail with this change. I will work on a fix.

@gpshead gpshead self-requested a review September 10, 2019 15:00
@vstinner vstinner closed this Jan 30, 2020
@vstinner vstinner deleted the test_socket_discovery branch January 30, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes

@gpshead gpshead Awaiting requested review from gpshead

+1 more reviewer

@Seluj78 Seluj78 Seluj78 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vstinner vstinner

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @Seluj78 @zware @the-knights-who-say-ni @bedevere-bot