Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 13, 2017

now becames invalid after advancing the groupby iterator.
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label May 13, 2017
@mention-bot
Copy link

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rhettinger, @kristjanvalur and @tiran to be potential reviewers.

@serhiy-storchaka serhiy-storchaka changed the title bpo-30346: An iterator produced by itertools.groupby() iterator bpo-30346: Invalidate groupby() sub-iterator when move the primary iterator May 13, 2017
Copy link
Contributor

@kristjanvalur kristjanvalur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@serhiy-storchaka
Copy link
Member Author

Closed in favor of #1569.

@serhiy-storchaka serhiy-storchaka deleted the groupby-invalid branch September 24, 2017 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants