Skip to content

bpo-37921: Better handle symlinks in the zipfile module#15401

Open
zaphodef wants to merge 4 commits intopython:mainfrom
zaphodef:feature/zipfile_modes
Open

bpo-37921: Better handle symlinks in the zipfile module#15401
zaphodef wants to merge 4 commits intopython:mainfrom
zaphodef:feature/zipfile_modes

Conversation

@zaphodef
Copy link
Copy Markdown

@zaphodef zaphodef commented Aug 22, 2019

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@raulcd
Copy link
Copy Markdown
Contributor

raulcd commented Aug 23, 2019

Hi @zaphodef thanks for the PR and the feature request.
Feature requests are usually being discussed on the python-ideas mailing list or at the bpo itself.
The documentation PR is failing due to:
Doc/library/zipfile.rst:655:Explicit markup ends without a blank line; unexpected unindent.

Copy link
Copy Markdown
Author

@zaphodef zaphodef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed is_reg() and added some tests in ca5e302 (for the follow_symlinks option and the filemode attribute).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 7, 2026
@sharkwouter
Copy link
Copy Markdown

sharkwouter commented Apr 7, 2026

Please don't close this, this is a necessary change for my use case. I maintain Minigalaxy and have been waiting for 7 years for this and the ability to preserve permissions when unpacking a zip. Right now I am using the unzip command through subprocess. Could I do something to help move this along? Is anything missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants