gh-81989: Deprecate passing a single argument to super()#15205
Open
ZackerySpytz wants to merge 1 commit intopython:mainfrom
Open
gh-81989: Deprecate passing a single argument to super()#15205ZackerySpytz wants to merge 1 commit intopython:mainfrom
ZackerySpytz wants to merge 1 commit intopython:mainfrom
Conversation
epicfaace
reviewed
Aug 27, 2019
| :func:`super`, see `guide to using super() | ||
| <https://rhettinger.wordpress.com/2011/05/26/super-considered-super/>`_. | ||
|
|
||
| .. deprecated:: 3.9 |
Contributor
There was a problem hiding this comment.
Should we also mention that it's deprecated earlier on in the file where it says "If the second argument is omitted, the super object returned is unbound."?
|
|
||
| if (PyTuple_GET_SIZE(args) == 1 && | ||
| PyErr_WarnEx(PyExc_DeprecationWarning, | ||
| "Passing 1 argument to super() is deprecated", 1) < 0) { |
Contributor
There was a problem hiding this comment.
"Passing a single argument" might sound better / be more consistent with the rest of the wording, for the deprecation message, too.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37808