Skip to content

bpo-37794: MSVCCompiler: Replace /Ox with /O2#15179

Closed
Kojoley wants to merge 1 commit intopython:mainfrom
Kojoley:msvc-replace-ox-with-o2
Closed

bpo-37794: MSVCCompiler: Replace /Ox with /O2#15179
Kojoley wants to merge 1 commit intopython:mainfrom
Kojoley:msvc-replace-ox-with-o2

Conversation

@Kojoley
Copy link
Copy Markdown

@Kojoley Kojoley commented Aug 8, 2019

The /O2 is a superset of /Ox with additional /GF and /Gy switches which
enables strings and functions deduplication and almost always are
favorable optimizations without downsides.

https://docs.microsoft.com/en-us/cpp/build/reference/ox-full-optimization

https://bugs.python.org/issue37794

The /O2 is a superset of /Ox with additional /GF and /Gy switches which
enables strings and functions deduplication and almost always are
favorable optimizations without downsides.

https://docs.microsoft.com/en-us/cpp/build/reference/ox-full-optimization
@Kojoley Kojoley force-pushed the msvc-replace-ox-with-o2 branch from b7a8c5b to 47bfffd Compare August 8, 2019 17:30
Copy link
Copy Markdown
Contributor

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Do we also need to change this line?

print('c_debug=/Ox')

@@ -0,0 +1 @@
:class:`distutils.MSVCCompiler` now uses ``/O2`` switch instead of ``/Ox``. No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:class:`distutils.MSVCCompiler` now uses ``/O2`` switch instead of ``/Ox``.
:class:`distutils.MSVCCompiler` now uses the ``/O2`` optimization instead of ``/Ox``.

@Kojoley
Copy link
Copy Markdown
Author

Kojoley commented Aug 28, 2019

Sounds good.

Do we also need to change this line?

print('c_debug=/Ox')

I know nothing about that code. It does not belong to distutils, so it is out of scope of my intentions too. If the only code it affects is a wrapper code that the file contains - it is probably not worth bothering.

@EvgenKo423
Copy link
Copy Markdown

It's been a year, any progress on this? @Kojoley, you've got a feedback on bug tracker. Could you please finish with this?

@Kojoley
Copy link
Copy Markdown
Author

Kojoley commented Dec 4, 2020

No, I am sorry, there is too much time consuming bureaucracy for a simple thing.

@iritkatriel
Copy link
Copy Markdown
Member

Closing this PR following the closure of its b.p.o. issue (https://bugs.python.org/issue37794)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants