[3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814)#14772
Merged
larryhastings merged 2 commits intopython:3.5from Sep 7, 2019
vstinner:urlnorm35
Merged
[3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814)#14772larryhastings merged 2 commits intopython:3.5from vstinner:urlnorm35
larryhastings merged 2 commits intopython:3.5from
vstinner:urlnorm35
Conversation
Member
Author
|
https://bugs.python.org/issue36742 is not fully fixed in the 3.5 branch: commit 4655d57 wasn't enough. We also need this second fix which is a backport from Python 3.6. |
Contributor
|
Just to confirm: this PR doesn't change any code in the standard library. It only changes tests. That's what you wanted? |
Member
Author
|
It changes the urllib module. I backported the change, I didn't make any change. |
|
@larryhastings: Please replace |
Contributor
|
Thanks for the 3.5 backport love! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 8d0ef0b)
Co-authored-by: Steve Dower steve.dower@python.org
(cherry picked from commit fd1771d)
https://bugs.python.org/issue36742