Skip to content

[2.7] bpo-37124: Fix reference leak in test_msilib (GH-13750) #14340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Jun 24, 2019
Merged

[2.7] bpo-37124: Fix reference leak in test_msilib (GH-13750) #14340

vstinner merged 1 commit into from
Jun 24, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 24, 2019 •
edited by bedevere-bot
Loading

(cherry picked from commit c0295db)

https://bugs.python.org/issue37124

@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir labels Jun 24, 2019
@vstinner
Copy link
Member Author

vstinner commented Jun 24, 2019

Compared to the change in master, I also added:

        self.addCleanup(unlink, db_path)
        self.addCleanup(db.Close)

@vstinner
Copy link
Member Author

vstinner commented Jun 24, 2019

self.addCleanup(db.Close) doesn't work: AttributeError: '_msi.Database' object has no attribute 'Close'.

I removed:

        self.addCleanup(unlink, db_path)
        self.addCleanup(db.Close)

@vstinner vstinner merged commit 6cbff56 into python:2.7 Jun 24, 2019
@vstinner vstinner deleted the test_msilib27 branch June 24, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @the-knights-who-say-ni @bedevere-bot @pablogsal