gh-140481: avoid misleading exception in tk.Tk.__getitem__#140483
Closed
TheLizzard wants to merge 1 commit into
Closed
gh-140481: avoid misleading exception in tk.Tk.__getitem__#140483TheLizzard wants to merge 1 commit into
tk.Tk.__getitem__#140483TheLizzard wants to merge 1 commit into
Conversation
tk.Tk.__getitem__
picnixz
reviewed
Oct 22, 2025
picnixz
left a comment
Member
There was a problem hiding this comment.
I'm not sure this is the correct way to fix this. We should instead check if option is a string in cget and if not raise a TypeError here.
Author
|
That might be better but then for consistency sake, we would have to add a lot of type checks to functions like I don't know what the best course of action is. |
Member
|
See #140501. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Code like:
Would throw a
TypeError: can only concatenate str (not "int") to strSummary of changes
"option" in <tk.Misc>__contain__method totk.Miscsince it already has__getitem__and__setitem__Testing
./python -m test test_tkinter -u=guilocally to make sure the old tests as well as the new ones passTk.__getitem__#140481