Skip to content

gh-137481: fix test expectations on some platforms#138156

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
kulikjak:fix-abbreviated-days-test
Aug 26, 2025
Merged

gh-137481: fix test expectations on some platforms#138156
serhiy-storchaka merged 3 commits into
python:mainfrom
kulikjak:fix-abbreviated-days-test

Conversation

@kulikjak

@kulikjak kulikjak commented Aug 26, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The recently introduced test_locale_calendar_long_weekday_names expects abbreviated weekday names to be three characters long, which is not the case on Oracle Solaris. In case of "pt_PT.UTF-8" locale:

>>> import calendar
>>> print(list(calendar.day_name))
['segunda-feira', 'terça-feira', 'quarta-feira', 'quinta-feira', 'sexta-feira', 'sábado', 'domingo']
>>> print(list(calendar.day_abbr))
['segunda', 'terça', 'quarta', 'quinta', 'sexta', 'sábado', 'domingo']

This makes the test work in such cases as well.

@kulikjak kulikjak requested a review from AA-Turner as a code owner August 26, 2025 09:15
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Aug 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 26, 2025
Closed
@kulikjak kulikjak mentioned this pull request Aug 26, 2025
Merged
serhiy-storchaka
serhiy-storchaka reviewed Aug 26, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I have some suggestions that reflect the original purpose of the test.

Comment thread Lib/test/test_calendar.py Outdated
Comment thread Lib/test/test_calendar.py Outdated
kulikjak and others added 2 commits August 26, 2025 12:38
@kulikjak @serhiy-storchaka
make the test slightly stricter
fe30a97 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@kulikjak @serhiy-storchaka
don't change the original purpose of the test
e6bc8b2 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@kulikjak

kulikjak commented Aug 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks for the suggestions, it's fixed now.

EDIT: and retested, just to be sure ;).

serhiy-storchaka
serhiy-storchaka approved these changes Aug 26, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Thank you for your continued support of Python on Solaris.

@serhiy-storchaka serhiy-storchaka merged commit f60f822 into python:main Aug 26, 2025
49 checks passed
@kulikjak

kulikjak commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for merging my changes 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kulikjak @serhiy-storchaka