gh-136190: dis.py: No line number in case of an artificial bytecode instruction #136923
Conversation
…ode instruction, then we show the last known line number.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
In the future, please add the issue number to the title (I have edited this prs title to the correct format) so that it can be automatically linked. |
StanFromIreland
left a comment
There was a problem hiding this comment.
Familiarise yourself with the current layout of stdlib tests, and move your tests there. They should be updated to use unittest like the existing tests, and cleaned up, removing commented out tests.
|
I'm not sure it's useful to change For example, you said on the issue: "disadvantage: other inspection tool would then still show no line number". |
|
I agree. I would rather fix the location on the interpreter's side rather than in |
|
So let's close this PR. |
This is a proposal to fix gh-136190 (at least in
dis).If the compiler returns no line number in case of an artificial bytecode instruction, then we show the last known line number.