gh-135726: multiprocessing.freeze_support no longer sets the start method globally.#135810
Open
aisk wants to merge 4 commits intopython:mainfrom
Open
gh-135726: multiprocessing.freeze_support no longer sets the start method globally.#135810aisk wants to merge 4 commits intopython:mainfrom
aisk wants to merge 4 commits intopython:mainfrom
Conversation
gpshead
reviewed
Jun 26, 2025
Member
gpshead
left a comment
There was a problem hiding this comment.
Could you come up with a meaningful regression test for this?
gpshead
reviewed
Jun 26, 2025
Member
Author
|
Thank you for the review, updated! |
|
@aisk This second commit will not break the patches I already have in use in cx_Freeze, because I monkeypatched freeze_support. And it does not interfere with the start method in Python (since it is not frozen). On Windows, this should work as it was before the PR that caused the regression. On Linux and macOS, I will continue monkeypatching until the gh-76327 is applied. |
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.