[3.7] bpo-36965: replace include of crtdbg.h with windows.h, backport 925af1d 3.7 (GH-13421)#13471
Merged
vstinner merged 3 commits intopython:3.7from May 22, 2019
Merged
Conversation
…ythonGH-13421) Include windows.h rather than crtdbg.h to get STATUS_CONTROL_C_EXIT constant. Moreover, include windows.h on Windows, not only when MSC is used. (cherry picked from commit 925af1d)
…lers (pythonGH-13421) Include windows.h rather than crtdbg.h to get STATUS_CONTROL_C_EXIT constant. Moreover, include windows.h on Windows, not only when MSC is used.. (cherry picked from commit 925af1d) Co-authored-by: Erik Janssens <erik.janssens@conceptive.be>
eamanu
reviewed
May 22, 2019
Contributor
eamanu
left a comment
There was a problem hiding this comment.
looks good. But I think that will be open a issue an explain a little more
what are you doing that :-)
Contributor
Author
|
it's a manual backport of GH-13421, this is the first time I went trough the manual cherry picking process ... so I didn't notice the required title format ... |
Member
|
I fixed the commit message and merged your PR, thanks. |
Contributor
Author
|
Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36965