gh-64243: Implement locale.getlocale fall back in gettext.find#131477
Open
StanFromIreland wants to merge 12 commits intopython:mainfrom
Open
gh-64243: Implement locale.getlocale fall back in gettext.find#131477StanFromIreland wants to merge 12 commits intopython:mainfrom
locale.getlocale fall back in gettext.find#131477StanFromIreland wants to merge 12 commits intopython:mainfrom
Conversation
Member
Author
|
request: @tomasr8 |
tomasr8
reviewed
Mar 30, 2025
tomasr8
reviewed
Apr 5, 2025
Member
Author
|
@serhiy-storchaka Could you please review this? |
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
There are issues with using locale.getlocale(). It ignores the modifier and can raise ValueError. I suggest to use locale._setlocale().
Needed tests for locales "C", "C.UTF-8", locales with a modifier, locales with and without encoding.
To help testing, you can extract the code into the _guess_languages() function.
Member
Author
|
There are several existing tests (from a previous pr) for the C locale. |
Member
Author
|
CIs don’t have some locale, I will have to add requirements. |
Member
Author
|
@tomasr8 as the expert now, could I get a review:-) |
Member
|
I can have a look this weekend, though I'd still prefer to get a final signoff from Serhiy :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LANGUAGES envvar is prioritized over getlocale for consistency with C gettext.
📚 Documentation preview 📚: https://cpython-previews--131477.org.readthedocs.build/