Skip to content

Don't import wait from connection#13112

Merged
gpshead merged 1 commit intopython:masterfrom
brianquinlan:wait-shadow
May 7, 2019
Merged

Don't import wait from connection#13112
gpshead merged 1 commit intopython:masterfrom
brianquinlan:wait-shadow

Conversation

@brianquinlan
Copy link
Copy Markdown
Contributor

This import causes an argument parameter to shadow the global import name.

This import causes an argument parameter to shadow the global import name.
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@gpshead
Copy link
Copy Markdown
Member

gpshead commented May 7, 2019

I put 'skip issue' and 'skip news' on here as this is effectively a lint error cleanup within the module. zero functional changes.

@gpshead gpshead merged commit f7bda5c into python:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants