gh-127443: add tool for linting Doc/data/refcounts.dat#127476
Closed
picnixz wants to merge 32 commits intopython:mainfrom
Closed
gh-127443: add tool for linting Doc/data/refcounts.dat#127476picnixz wants to merge 32 commits intopython:mainfrom
Doc/data/refcounts.dat#127476picnixz wants to merge 32 commits intopython:mainfrom
Conversation
bc45547 to
183388f
Compare
Eclips4
reviewed
Dec 1, 2024
AlexWaygood
reviewed
Dec 1, 2024
AlexWaygood
reviewed
Dec 1, 2024
AlexWaygood
reviewed
Dec 1, 2024
AlexWaygood
reviewed
Dec 2, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Nice. I haven't reviewed the script as I know nothing about the refcounts.dat file, but the lint configs LGTM.
Member
Author
|
I don't think I'll change the configs. So thanks Alex for your review (and sorry for the request, I misclicked)! Now, I'll wait for Peter and Kirill's reviews concerning the script itself. |
hugovk
reviewed
Dec 2, 2024
(to shorten lines)
AlexWaygood
reviewed
Dec 2, 2024
Member
Author
|
Marking it as |
Member
Author
|
Considering I haven't been able to work on this one since last year, I'm going to close it. I think @ZeroIntensity wanted to do a similar work so I'll let him do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tool can be used as follows:
With the current file, I have something like: (three were missing in #127451, my bad, so I fixed them as well)
When I also include the stable ABI file, I have in addition (output truncated)
Doc/data/refcounts.dat#127443