gh-126944: Better error for missing arg in pdb#126945
Closed
hauntsaninja wants to merge 3 commits intopython:mainfrom
Closed
gh-126944: Better error for missing arg in pdb#126945hauntsaninja wants to merge 3 commits intopython:mainfrom
hauntsaninja wants to merge 3 commits intopython:mainfrom
Conversation
Wulian233
reviewed
Nov 18, 2024
| @@ -1774,6 +1774,9 @@ def _getval(self, arg): | |||
| try: | |||
| return eval(arg, self.curframe.f_globals, self.curframe.f_locals) | |||
| except: | |||
Contributor
There was a problem hiding this comment.
Could we add more detailed error handling, even if it's just
expect Exception:would be better
Member
|
This might be the minimum amount of code to fix the issue, but I don't think this is the correct place. It's not obvious why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.