Skip to content

[3.13] gh-122666: Tests for ast optimizations (GH-122667)#123359

Merged
JelleZijlstra merged 3 commits intopython:3.13from
miss-islington:backport-9f9b00d-3.13
Aug 27, 2024
Merged

[3.13] gh-122666: Tests for ast optimizations (GH-122667)#123359
JelleZijlstra merged 3 commits intopython:3.13from
miss-islington:backport-9f9b00d-3.13

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Aug 26, 2024

(cherry picked from commit 9f9b00d)

Co-authored-by: Kirill Podoprigora kirill.bast9@mail.ru
Co-authored-by: Sergey B Kirpichev skirpichev@gmail.com
Co-authored-by: Victor Stinner vstinner@python.org
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com

(cherry picked from commit 9f9b00d)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra
Copy link
Copy Markdown
Member

cc @Eclips4 the tests are failing because ast.compare didn't exist in 3.13. We'll probably have to add a simple version of compare just in the test; maybe can simply ast.dump() both trees and string compare them.

@Eclips4 Eclips4 self-assigned this Aug 27, 2024
@Eclips4 Eclips4 requested a review from JelleZijlstra August 27, 2024 07:22
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JelleZijlstra JelleZijlstra merged commit 69b104a into python:3.13 Aug 27, 2024
@miss-islington miss-islington deleted the backport-9f9b00d-3.13 branch January 2, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants