gh-123341: Support tkinter.Event type subcript#123353
gh-123341: Support tkinter.Event type subcript#123353AlexWaygood merged 9 commits intopython:mainfrom
tkinter.Event type subcript#123353Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
tkinter.Event subscriptabletkinter.Event type subcript
|
Is this the only class in tkinter that needs this treatment? |
|
Thanks for the review it's a bit late now, will be resolving everything tomorrow. Is this significant enough to require a news entry? If so, let me know. I couldn't find any other classes that need to implement this behaviour (in tkinter at least, the stdlib as a whole has plenty), so yeah, that should be the only class. |
|
Yes, add a news entry |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @sobolevn: please review the changes made to this pull request. |
|
Looks like |
|
Our tkinter doc is deficient unless one considers it as incorporating other docs by reference, in which case Event is well documented. Its details are essential for working with events. But that does not help the role linker. Add |
|
Should be good to go now |
Adds
__class_getitem__totkinter.Eventand addstkinter.Eventto the list of generic typestkinter.Eventis not subscriptable at runtime but generic in stub file #123341