[3.7] bpo-35121: prefix dot in domain for proper subdomain validation (GH-10258) #12259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onGH-10258) Don't send cookies of domain A without Domain attribute to domain B when domain A is a suffix match of domain B while using a cookiejar with `http.cookiejar.DefaultCookiePolicy` policy. Patch by Karthikeyan Singaravelan. (cherry picked from commit ca7fe50) Co-authored-by: Xtreak <tir.karthi@gmail.com>
Contributor
Author
|
@tirkarthi and @ned-deily: Status check is done, and it's a failure ❌ . |
Contributor
Author
|
@tirkarthi and @ned-deily: Status check is done, and it's a failure ❌ . |
Member
|
I'm not sure why the appveyor run failed. I tried closing and re-opening the PR to rerun the CI tests but miss-islington was too fast for me and deleted the branch before it could the PR could be re-opened. So I just let a new 3.7 backport be created (#12261). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't send cookies of domain A without Domain attribute to domain B when domain A is a suffix match of domain B while using a cookiejar with
http.cookiejar.DefaultCookiePolicypolicy. Patch by Karthikeyan Singaravelan.(cherry picked from commit ca7fe50)
Co-authored-by: Xtreak tir.karthi@gmail.com
https://bugs.python.org/issue35121