gh-119993 ignore NotADirectoryError in Path.unlink() if missing_ok is True#120049
Open
MusicalNinjaDad wants to merge 13 commits intopython:mainfrom
Open
gh-119993 ignore NotADirectoryError in Path.unlink() if missing_ok is True#120049MusicalNinjaDad wants to merge 13 commits intopython:mainfrom
NotADirectoryError in Path.unlink() if missing_ok is True#120049MusicalNinjaDad wants to merge 13 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a short note on when Path.unlink() raises
NotADirectoryErrorThis can occur "in the wild", for example, after calling
shutil.move(src, dst)wheredstis a non-existent directory. Debugging can cost a lot of time as the cause can be non-intuitive, potentially not nearby in the code and the docs don't mention the exception as being raised in any circumstances.(This just happened to me after encountering pypa/cibuildwheel#1850)
Fixes: #119993
NotADirectoryErrorif some element of the path is actually a file - this is undocumented #119993📚 Documentation preview 📚: https://cpython-previews--120049.org.readthedocs.build/