[3.12] gh-119311: Fix name mangling with PEP 695 generic classes (#119464)#119644
[3.12] gh-119311: Fix name mangling with PEP 695 generic classes (#119464)#119644Yhg1s merged 3 commits intopython:3.12from
Conversation
python#119464) Fixes python#119311. Fixes python#119395. (cherry picked from commit a9a74da)
|
"Check if the ABI has changed" is failing, this is what I was worried about. I'll try to think of a solution that doesn't involve new entries on the struct. |
|
My recollection (admittedly vague) is that the ABI dump doesn't try to distinguish internal ABI, so an ABI check failure isn't a definitive no-go, it just means RM should take a look. If we are concerned that someone might be building with |
|
Yes, I think it makes sense to backport this to 3.12. The ABI breakage doesn't matter because the structs aren't visible as Carl said, and the new function is fine because it's private and not used by extension modules, just the core itself. You do need to regen the ABI dump as part of the PR. |
|
I couldn't get the abi regen tool to run locally (I tried the instructions in https://devguide.python.org/getting-started/setup-building/#regenerate-the-abi-dump but got errors related to mpdecimal). But I was able to edit the dump file manually and the check succeeds now. |
Fixes #119311. Fixes #119395.
(cherry picked from commit a9a74da)